Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rust): Add a test for AnonymousScan options (projection and slice pushdown) #17149

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

datapythonista
Copy link
Contributor

Adding Ritchie's test from #17131 to the test suite.

I just made a couple of small changes from the one in the issue:

  • Instead of comparing the options to None, I check that the length of the projection and the slice are correct.
  • I added a with_column to the query, which I think was causing my original problem.

@stinodego stinodego changed the title Add a test for AnonymousScan options (projection and slice pushdown) test(rust): Add a test for AnonymousScan options (projection and slice pushdown) Jun 23, 2024
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jun 23, 2024
@ritchie46 ritchie46 merged commit 42ba1b0 into pola-rs:main Jun 24, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants