perf: Parallelize arrow conversion if binview -> large_bin #17083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
performance
|
Thanks but I read as string as data is messed up but then later convert to double ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@djouallah created a benchmark with only string columns and calls
to_arrow.Because Polars has adopted the new string-view type, we are conservative and must covert to the old
large-string. This conversion must move all data. Therefore let's make it parallel.You can default to
string-viewin pyarrow 16 by settingto_arrow(future=True), but the delta-writer still doesn't support that datatype. delta-io/delta-rs#2613