docs: Fix some warnings during doc build #17077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17077 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 1456 1456
Lines 191141 191140 -1
Branches 2728 2730 +2
=======================================
+ Hits 154562 154567 +5
+ Misses 36073 36066 -7
- Partials 506 507 +1 ☔ View full report in Codecov by Sentry. |
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
ritchie46
reviewed
Jun 20, 2024
py-polars/src/lazyframe/mod.rs
Outdated
| @@ -512,6 +512,9 @@ impl PyLazyFrame { | |||
| ldf = ldf.with_new_streaming(new_streaming); | |||
| } | |||
|
|
|||
| if streaming { | |||
There was a problem hiding this comment.
This shouldn't be toggled here. It is already toggled.
I think we can turn that warning off, but python should pass the settings as is.
There was a problem hiding this comment.
All right, removed the warning & updated the Python side accordingly!
ritchie46
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.