Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Expand i128 primitive type match #17076

Merged

Conversation

Kylea650
Copy link
Contributor

Closes #16111

Update primitive match to use with_match_primitive_type_full! macro instead.

The original with_match_primitive_type! macro now only remains for the polars_arrow::compute::aggregate::sum function. This is due to not being able to implement simd_sum for f16 types: rust-lang/rust#116909.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (535027a) to head (abaa877).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/polars-arrow/src/array/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17076      +/-   ##
==========================================
- Coverage   80.87%   80.86%   -0.01%     
==========================================
  Files        1455     1455              
  Lines      191020   191093      +73     
  Branches     2723     2724       +1     
==========================================
+ Hits       154487   154535      +48     
- Misses      36029    36054      +25     
  Partials      504      504              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 46ba436 into pola-rs:main Jun 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"operator does not support primitive Int128" when using Decimal from arrow_array
2 participants