feat: Print row index in explain and show_graph
#17074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the explanation when calling `explain` or `show_graph` on a scan. It now: - more neatly formats the paths, - displays the row_index if it is defined, - does not count the row_index as a column in the total_columns.
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17074 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 1455 1455
Lines 191086 191090 +4
Branches 2723 2723
=======================================
+ Hits 154519 154524 +5
+ Misses 36063 36062 -1
Partials 504 504 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jun 20, 2024
stinodego
changed the title
explain and show_graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the explanation when calling
explainorshow_graphon a scan. It now: