feat: Turn of coalescing and fix mutation of join on expressions #17061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
enhancement
wence-
added a commit
to wence-/cudf
that referenced
this pull request
Jun 25, 2024
This is closer to the SQL behaviour and was changed by polars in pola-rs/polars#17061.
wence-
added a commit
to wence-/cudf
that referenced
this pull request
Jun 26, 2024
This is closer to the SQL behaviour and was changed by polars in pola-rs/polars#17061.
wence-
added a commit
to wence-/cudf
that referenced
this pull request
Jun 26, 2024
This is closer to the SQL behaviour and was changed by polars in pola-rs/polars#17061.
wence-
added a commit
to wence-/cudf
that referenced
this pull request
Jun 27, 2024
This is closer to the SQL behaviour and was changed by polars in pola-rs/polars#17061.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joining on any expression other than
colwill turn off coalescing behavior and will keep all columns of both tables. This also fixes several bugs with regard to accidentally mutating the underlying columns and adding literal expressions to the tables.fixes #13220
fixes #9621