Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): fix get categories on multiple row groups #17041

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

c-peters
Copy link
Collaborator

fix #16916

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Jun 18, 2024
@ritchie46
Copy link
Member

Can we add a test?

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (5bb28b4) to head (82a5ec6).
Report is 52 commits behind head on main.

Current head 82a5ec6 differs from pull request most recent head 91c1ea4

Please upload reports for the commit 91c1ea4 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17041      +/-   ##
==========================================
- Coverage   81.09%   81.00%   -0.10%     
==========================================
  Files        1435     1448      +13     
  Lines      189567   190551     +984     
  Branches     2712     2723      +11     
==========================================
+ Hits       153736   154353     +617     
- Misses      35331    35695     +364     
- Partials      500      503       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 9076097 into pola-rs:main Jun 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate values from .cat.get_categories
2 participants