Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix projection pushdown with literal joins #16981

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix: Fix projection pushdown with literal joins #16981

merged 1 commit into from
Jun 16, 2024

Conversation

ritchie46
Copy link
Member

fixes #11410

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 16, 2024
Copy link

codspeed-hq bot commented Jun 16, 2024

CodSpeed Performance Report

Merging #16981 will degrade performances by 17.56%

Comparing join (80179c8) with main (9e3e9b0)

Summary

❌ 1 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main join Change
test_tpch_q3 5.4 ms 6.5 ms -17.56%

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (9a3e032) to head (80179c8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16981      +/-   ##
==========================================
- Coverage   81.04%   81.03%   -0.01%     
==========================================
  Files        1445     1445              
  Lines      190301   190320      +19     
  Branches     2709     2709              
==========================================
+ Hits       154224   154232       +8     
- Misses      35579    35591      +12     
+ Partials      498      497       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1effc24 into main Jun 16, 2024
27 checks passed
@ritchie46 ritchie46 deleted the join branch June 16, 2024 06:53
@mcrumiller
Copy link
Contributor

@ritchie46 related #9621, why does the join result in a literal column at all? If on clauses are intended to generate columns, we should be able to alias them, but we can't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread '<unnamed>' panicked when dropping column
2 participants