Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Extend new streaming engine with some initial nodes #16940

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jun 13, 2024

This is very much work-in-progress, but don't want to create very large PRs.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 269 lines in your changes missing coverage. Please review.

Project coverage is 80.97%. Comparing base (5bb28b4) to head (7c55955).

Files Patch % Lines
crates/polars-stream/src/nodes/in_memory_sink.rs 0.00% 56 Missing ⚠️
crates/polars-stream/src/nodes/in_memory_source.rs 0.00% 43 Missing ⚠️
crates/polars-stream/src/morsel.rs 0.00% 36 Missing ⚠️
crates/polars-stream/src/graph.rs 0.00% 31 Missing ⚠️
crates/polars-stream/src/nodes/filter.rs 0.00% 29 Missing ⚠️
...rates/polars-stream/src/nodes/simple_projection.rs 0.00% 26 Missing ⚠️
crates/polars-stream/src/physical_plan/to_graph.rs 0.00% 17 Missing ⚠️
crates/polars-stream/src/skeleton.rs 0.00% 16 Missing ⚠️
crates/polars-stream/src/lib.rs 0.00% 5 Missing ⚠️
crates/polars-stream/src/execute.rs 0.00% 4 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16940      +/-   ##
==========================================
- Coverage   81.09%   80.97%   -0.13%     
==========================================
  Files        1435     1445      +10     
  Lines      189567   189810     +243     
  Branches     2712     2712              
==========================================
- Hits       153736   153691      -45     
- Misses      35331    35619     +288     
  Partials      500      500              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e1bd5da into main Jun 13, 2024
22 checks passed
@ritchie46 ritchie46 deleted the streaming-engine branch June 13, 2024 18:09
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
@stinodego stinodego changed the title refactor: extend new streaming engine with some initial nodes refactor(rust): Extend new streaming engine with some initial nodes Jun 30, 2024
@stinodego stinodego removed the python Related to Python Polars label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants