Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump object_store from 0.9 to 0.10 #16920

Merged
merged 11 commits into from
Jun 13, 2024
Merged

build: Bump object_store from 0.9 to 0.10 #16920

merged 11 commits into from
Jun 13, 2024

Conversation

ritchie46
Copy link
Member

I couldn't push to the branch, so a new pr.

@ritchie46
Copy link
Member Author

supersedes #16903

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (38149d6) to head (986cb7d).
Report is 55 commits behind head on main.

Files Patch % Lines
crates/polars-io/src/cloud/adaptors.rs 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16920      +/-   ##
==========================================
- Coverage   81.39%   81.08%   -0.32%     
==========================================
  Files        1424     1435      +11     
  Lines      187623   189537    +1914     
  Branches     2691     2708      +17     
==========================================
+ Hits       152719   153686     +967     
- Misses      34409    35352     +943     
- Partials      495      499       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 13, 2024

CodSpeed Performance Report

Merging #16920 will improve performances by 21.6%

Comparing object_store (986cb7d) with main (a61dcb4)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main object_store Change
test_groupby_h2oai_q1 2.7 ms 2.3 ms +21.6%

@ritchie46 ritchie46 merged commit e29d28e into main Jun 13, 2024
21 checks passed
@ritchie46 ritchie46 deleted the object_store branch June 13, 2024 08:34
@stinodego stinodego changed the title build(rust): bump object_store 0.9 -> 0.10 build: Bump object_store from 0.9 to 0.10 Jun 13, 2024
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants