perf: Improve rle_id iteration performance and set sorted flags
#16893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
performance
ritchie46
commented
Jun 12, 2024
| } | ||
| } | ||
|
|
||
| let outvals = vec![Series::from_vec("len", lengths), vals.to_owned()]; | ||
| Ok(StructChunked::new("rle", &outvals)?.into_series()) | ||
| Ok(StructChunked::new(s.name(), &outvals)?.into_series()) |
There was a problem hiding this comment.
We should always keep names.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16893 +/- ##
=======================================
Coverage 81.41% 81.42%
=======================================
Files 1425 1425
Lines 187964 187973 +9
Branches 2704 2704
=======================================
+ Hits 153027 153053 +26
+ Misses 34440 34423 -17
Partials 497 497 ☔ View full report in Codecov by Sentry. |
stinodego
changed the title
rle_id iteration performance and set sorted flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster iteration and set proper flags. closes #16887