depr(python): Rename parameter descending to reverse in top_k methods
#16817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
deprecation
stinodego
force-pushed
the
depr-top-k-descending
branch
from
b17f51f to
c24b00a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16817 +/- ##
==========================================
- Coverage 81.39% 81.39% -0.01%
==========================================
Files 1424 1424
Lines 187623 187626 +3
Branches 2691 2697 +6
==========================================
- Hits 152719 152711 -8
- Misses 34409 34420 +11
Partials 495 495 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15236
Changes
descendingparameter toreverseinDataFrame/LazyFrame.top_k/bottom_kandExpr.top_k_by/bottom_k_by.