Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Expose a few more expression nodes in the expression IR #16781

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

wence-
Copy link
Collaborator

@wence- wence- commented Jun 6, 2024

A bunch of "easy" nodes that complete coverage for translation of some useful benchmark queries.

Also, sends through the should_broadcast projection option that was introduced in #16682

wence- added 2 commits June 6, 2024 13:37
This is useful information for a consumer, that also needs to handle
the broadcasting (or not) semantics of CSE expressions.
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels Jun 6, 2024
@wence- wence- marked this pull request as draft June 6, 2024 14:25
@wence- wence- marked this pull request as ready for review June 6, 2024 14:28
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 3.57143% with 27 lines in your changes missing coverage. Please review.

Project coverage is 81.29%. Comparing base (616b2e0) to head (f8a030b).
Report is 23 commits behind head on main.

Files Patch % Lines
py-polars/src/lazyframe/visitor/expr_nodes.rs 0.00% 23 Missing ⚠️
py-polars/src/lazyframe/visitor/nodes.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16781      +/-   ##
==========================================
- Coverage   81.44%   81.29%   -0.15%     
==========================================
  Files        1413     1424      +11     
  Lines      186199   187224    +1025     
  Branches     2776     2714      -62     
==========================================
+ Hits       151654   152211     +557     
- Misses      34025    34516     +491     
+ Partials      520      497      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wence-
Copy link
Collaborator Author

wence- commented Jun 6, 2024

Failure looks like a temporary GHA network blip.

@stinodego
Copy link
Member

Failure looks like a temporary GHA network blip.

Yes, this is failing a lot today. You can ignore it!

@ritchie46 ritchie46 merged commit 1df442f into pola-rs:main Jun 7, 2024
17 of 18 checks passed
@wence- wence- deleted the wence/fea/more-pyir branch June 7, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants