-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Convert to given time zone in .str.to_datetime
when values are offset-aware
#16742
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16742 +/- ##
=======================================
Coverage 81.38% 81.38%
=======================================
Files 1425 1425
Lines 187606 187662 +56
Branches 2697 2702 +5
=======================================
+ Hits 152677 152732 +55
Misses 34434 34434
- Partials 495 496 +1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #16742 will degrade performances by 16.38%Comparing Summary
Benchmarks breakdown
|
cc9948b
to
3a57295
Compare
2753551
to
e35a344
Compare
.dt.to_datetime
when values are offset-aware
.dt.to_datetime
when values are offset-aware.str.to_datetime
when values are offset-aware
0af0cdd
to
5a400da
Compare
5a400da
to
733ccdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Left a very minor nitpick but is good to merge imo.
Thanks for picking this up.
thanks @stinodego ! cool, merging then |
.str.to_datetime
when values are offset-aware.str.to_datetime
when values are offset-aware
related to #16297
This only deals with the
.str.to_datetime
part, and makes the behaviour match the constructor behaviour in https://github.com/pola-rs/polars/pull/16828/files for offset-aware input and non-missingtime_zone
: