feat!: Enforce deprecation of offset arg in truncate and round
#16655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
MarcoGorelli
changed the title
offset arg in truncate and roundoffset arg in truncate and round
MarcoGorelli
added
the
do not merge
MarcoGorelli
force-pushed
the
remove-offset
branch
from
ead2e81 to
2f01f94
Compare
MarcoGorelli
commented
Jun 1, 2024
Comment on lines
64
to
-67
| pub fn truncate_ns(&self, t: i64, tz: Option<&Tz>) -> PolarsResult<i64> { | ||
| let t = self.every.truncate_ns(t, tz)?; | ||
| self.offset.add_ns(t, tz) | ||
| } |
There was a problem hiding this comment.
i was never a huge fan how of truncate_* would both truncate and apply an offset..
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16655 +/- ##
==========================================
+ Coverage 81.49% 81.54% +0.04%
==========================================
Files 1416 1414 -2
Lines 186880 186349 -531
Branches 3023 3010 -13
==========================================
- Hits 152289 151949 -340
+ Misses 34059 33870 -189
+ Partials 532 530 -2 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
ritchie46
approved these changes
Jun 4, 2024
|
Good to go. Can you rebase? |
stinodego
removed
the
do not merge
stinodego
changed the title
offset arg in truncate and roundoffset arg in truncate and round
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies quite a lot
This will make perf improvements for truncate and round easier
Adding "do not merge" for now, until it's finalised that it's time to merge things for 1.0