-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Dedicated SQLInterface
and SQLSyntax
errors
#16635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli,
reswqa,
orlp and
universalmind303
as code owners
May 31, 2024 14:15
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
labels
May 31, 2024
alexander-beedie
force-pushed
the
sql-exceptions
branch
from
May 31, 2024 14:28
c206b87
to
23d6966
Compare
alexander-beedie
changed the title
feat: Add dedicated
feat: Dedicated May 31, 2024
SQLInterface
and SQLSyntax
errorsSQLInterface
and SQLSyntax
errors
alexander-beedie
force-pushed
the
sql-exceptions
branch
from
May 31, 2024 14:38
23d6966
to
4c636e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16635 +/- ##
==========================================
- Coverage 81.51% 81.51% -0.01%
==========================================
Files 1414 1414
Lines 185995 186010 +15
Branches 3026 3026
==========================================
+ Hits 151608 151620 +12
- Misses 33856 33859 +3
Partials 531 531 ☔ View full report in Codecov by Sentry. |
Nice, I will wait until we can move the breaking PR's. |
ritchie46
approved these changes
Jun 1, 2024
stinodego
changed the title
feat: Dedicated
feat!: Dedicated Jun 2, 2024
SQLInterface
and SQLSyntax
errorsSQLInterface
and SQLSyntax
errors
stinodego
removed
breaking
Change that breaks backwards compatibility
skip changelog
Do not include in changelog
labels
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-sql
Area: Polars SQL functionality
breaking
Change that breaks backwards compatibility
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed, this implements dedicated SQL-specific errors.
(Currently it's a mix of
ComputeError
andInvalidOperation
).New errors:
SQLSyntaxError
: otherwise-supported syntax that was used incorrectly (for example: incorrect number of parameters passed to a valid SQL function).SQLInterfaceError
: almost every other error that can come specifically from the SQL interface (unimplemented functions, references to unregistered tables, etc).Also:
Examples
Syntax errors:
(function only expects 1-2 parameters)Interface error:
(syntax is fine, but no such table was registered)