feat(rust,py): add additional control to write_parquet::statistics parameter
#16575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
enhancement
coastalwhite
changed the title
write_parquet::statistics parameter
coastalwhite
force-pushed
the
write-statistics
branch
3 times, most recently
from
8c38cfa to
7ef6f45
Compare
|
I think the CI is having a small problem. |
coastalwhite
force-pushed
the
write-statistics
branch
from
7ef6f45 to
85cd7b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16575 +/- ##
==========================================
- Coverage 81.49% 81.46% -0.03%
==========================================
Files 1414 1416 +2
Lines 185561 186837 +1276
Branches 2997 3021 +24
==========================================
+ Hits 151219 152213 +994
- Misses 33826 34091 +265
- Partials 516 533 +17 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
May 30, 2024
ritchie46
reviewed
May 30, 2024
coastalwhite
force-pushed
the
write-statistics
branch
2 times, most recently
from
07f969a to
5a335d0
Compare
ritchie46
reviewed
Jun 1, 2024
coastalwhite
force-pushed
the
write-statistics
branch
2 times, most recently
from
a2c1c04 to
0d12846
Compare
CodSpeed Performance ReportMerging #16575 will not alter performanceComparing Summary
|
Adds additional control over which statistics are written into Parquet files through the `write_parquet` parameter `statistics`. It is now possible to specify `"full"` to also attempt to add the `distinct_count` statistic (currently only added for `Booleans`). It is also possible to give a `dict[str, bool]` to specify individual statistics `min`, `max`, `distinct_count` and `null_count`. Fixes pola-rs#16441
coastalwhite
force-pushed
the
write-statistics
branch
from
0d12846 to
a8b7b7c
Compare
ritchie46
reviewed
Jun 3, 2024
| .flatten() | ||
| .min_by(|x, y| ord_binary(x, y)) | ||
| .map(|x| x.to_vec()), | ||
| max_value: options |
There was a problem hiding this comment.
Now that we depend on polars-compute, can we use the kernels directly here? There are SIMD :)
| .map(|x| x.to_vec()) | ||
| }) | ||
| .flatten(), | ||
| min_value: options |
| .flatten() | ||
| .min_by(|x, y| ord_binary(x, y)) | ||
| .map(|x| x.to_vec()), | ||
| max_value: options |
| .map(|x| x.to_vec()), | ||
| max_value: options | ||
| .max_value | ||
| .then(|| { |
There was a problem hiding this comment.
Not sure if we got a kernel for this one. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional control over which statistics are written into Parquet files through the
write_parquetparameterstatistics.It is now possible to specify
"full"to also attempt to add thedistinct_countstatistic (currently only added forBooleans). It is also possible to give adict[str, bool]to specify individual statisticsmin,max,distinct_countandnull_count.Fixes #16441