Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix typo in deprecation message of with_row_count #13793

Merged
merged 4 commits into from
Jan 17, 2024
Merged

docs: Fix typo in deprecation message of with_row_count #13793

merged 4 commits into from
Jan 17, 2024

Conversation

langestefan
Copy link
Contributor

No description provided.

stinodego
stinodego approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up my mess 😄

@stinodego stinodego changed the title Fix typo in deprecation message of with_row_count docs: Fix typo in deprecation message of with_row_count Jan 17, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Jan 17, 2024
@mcrumiller
Copy link
Contributor

Can you also add a space in the first line of the @deprecate_function message (for both df and lazy)? It currently renders without a space after the period:

>>> pl.DataFrame().with_row_count()
...Use `with_row_index` instead.Note that ...

@stinodego stinodego merged commit 14440ca into pola-rs:main Jan 17, 2024
11 checks passed
@stinodego
Copy link
Member

Can you also add a space

Done, thanks!

r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 22, 2024
@langestefan @stinodego @r-brink
docs: Fix typo in deprecation message of with_row_count (pola-rs#13793
11a3ebd 
)

Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
@langestefan @stinodego @r-brink
docs: Fix typo in deprecation message of with_row_count (pola-rs#13793
86f0451 
)

Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli left review comments

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@langestefan @mcrumiller @stinodego @MarcoGorelli