Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Raise error instead of panic when joining on wildcard/nth #13742

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix: Raise error instead of panic when joining on wildcard/nth #13742

merged 2 commits into from
Jan 17, 2024

Conversation

stinodego
Copy link
Contributor

Closes #10663

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 15, 2024
@stinodego stinodego marked this pull request as ready for review January 15, 2024 11:22
ritchie46
ritchie46 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@stinodego stinodego changed the title fix: Raise error instead of panic when joining on wildcard fix: Raise error instead of panic when joining on wildcard/nth Jan 17, 2024
@stinodego stinodego marked this pull request as draft January 17, 2024 08:39
@stinodego stinodego marked this pull request as ready for review January 17, 2024 08:48
@stinodego stinodego merged commit be04ba2 into main Jan 17, 2024
22 checks passed
@stinodego stinodego deleted the wildcard-err branch January 17, 2024 09:24
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 22, 2024
@stinodego @r-brink
fix: Raise error instead of panic when joining on wildcard/nth (pola-…
9452499 
…rs#13742)
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
@stinodego @r-brink
fix: Raise error instead of panic when joining on wildcard/nth (pola-…
2ab9bb6 
…rs#13742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using wildcard as join key leads to panic
2 participants
@stinodego @ritchie46