-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert fixed-offset timezones to respective Etc timezone from time zone database #13738
Conversation
…time zone database
@@ -26,6 +30,18 @@ pub fn unix_time() -> NaiveDateTime { | |||
NaiveDateTime::from_timestamp_opt(0, 0).unwrap() | |||
} | |||
|
|||
#[cfg(feature = "timezones")] | |||
const FIXED_OFFSET_PATTERN: &str = r#"(?x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this one static. Doesn't have to be inlined everywhere we use it I would say. (or aren't we going to use it more often?)
Does/should this also work for parsing regular time zone inputs, e.g. |
For For csv files, they don't store dtypes anyway, so it's all good (and offset-aware inputs are converted to UTC, as they are in |
Right, |
…time zone database (pola-rs#13738)
closes #12893
demo with the example reported in the issue: