depr: Deprecate dt.with_time_unit in favor of cast(pl.Int64).cast(pl.Datetime(time_unit, time_zone))
#13667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deprecation
…e(time_unit, time_zone))
MarcoGorelli
force-pushed
the
depr-with-time-unit
branch
2 times, most recently
from
2d3f5a2 to
799ef4b
Compare
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters and
alexander-beedie
as code owners
stinodego
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Why do we have to cast to Int64 and then to the type we want? I would expect casting directly to work - we should implement that I think.
EDIT: I did not read the issue thoroughly enough. It makes sense to cast to Int64 first, otherwise it would be a cast_time_unit.
And I agree that we can drop this method as cast should take care of this.
stinodego
force-pushed
the
depr-with-time-unit
branch
from
288bc9b to
c2c6d4a
Compare
stinodego
force-pushed
the
depr-with-time-unit
branch
from
c2c6d4a to
26de758
Compare
stinodego
approved these changes
Jan 15, 2024
stinodego
changed the title
dt.with_time_unit in favor of cast(pl.Int64).cast(pl.Datetime(time_unit, time_zone))
|
😄 no worries, it's very easy to confuse them, thanks for your review |
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 15, 2024
…pl.Datetime(time_unit, time_zone))` (pola-rs#13667) Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 24, 2024
…pl.Datetime(time_unit, time_zone))` (pola-rs#13667) Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13209