Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(python): Doc example for read_csv (#13161) #13545

Merged
merged 2 commits into from
Jan 9, 2024
Merged

docs(python): Doc example for read_csv (#13161) #13545

merged 2 commits into from
Jan 9, 2024

Conversation

MarcNuebel
Copy link
Contributor

Part of #13161

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Jan 8, 2024
ritchie46
ritchie46 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@ritchie46 ritchie46 merged commit 607e6a2 into pola-rs:main Jan 9, 2024
14 checks passed
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Jan 9, 2024 •
edited
Loading

FYI: the # doctest: +SKIP directives aren't necessary here; this example will run successfully as the BytesIO object is created locally - otherwise looks good, thanks! We could definitely do with a few more examples, given the number of parameters available, so that's very welcome... (I'll tidy up the directives on my next commit) 👍

@MarcNuebel MarcNuebel mentioned this pull request Jan 9, 2024
Closed
MarcNuebel added a commit to MarcNuebel/polars that referenced this pull request Jan 28, 2024
@MarcNuebel
docs(python): More examples for read_csv
ea809ed 
Addition to pola-rs#13545 with unnecessary doctest skips removed.
Part of pola-rs#13161.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcNuebel @alexander-beedie @ritchie46