chore(python): clean up bytecode parsing a bit #13221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's 3 cleanups I'm suggesting here:
make
try
blocks smaller. I think this is uncontroversialremove an unused
try
block in_is_raw_function
. The whole test suite passes without it, I think it the code can be simplified by just removing itremoving the
_can_attempt_rewrite
dict. I think this was originally introduced for performance reasons, but:main
(timingpl.col('a').map_elements(lambda x: abs(x))
here and onmain
takes about8.988900013459247e-05
seconds on my laptopIt's already super-fast, I don't think the extra complexity is warranted