feat(rust): Impl serde for array dtype #13168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
reswqa
commented
Dec 21, 2023
reswqa
commented
Dec 21, 2023
reswqa
changed the title
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
reswqa
commented
Dec 22, 2023
reswqa
commented
Dec 25, 2023
Comment on lines
+38
to
42
| self.arrays | ||
| .push(NullArray::new(ArrowDataType::Null, self.width).boxed()); | ||
| match &mut self.validity { | ||
| Some(validity) => validity.push(false), | ||
| None => self.init_validity(), |
There was a problem hiding this comment.
I feel like I've found the culprit :). It seems we only consider the validity array in push_null. But unlike LargeListArray, there is no offsets array for FixedSizeListArray, causing our values to be confused with null value. After changing this, the test passed.
There was a problem hiding this comment.
Ah.. yes. It hurts that we need to box that every time, but that's what it is. :(
ritchie46
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #13151.