Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Add py-polars to Cargo workspace #12256

Merged
merged 5 commits into from
Nov 5, 2023
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Nov 5, 2023

This adds the py-polars crate to the workspace as a non-default member. Benefits:

  • Integrates everything in the workspace. Can run everything from the workspace root (clippy / build / ...). This will help simplify the CI in the future (for now, everything keeps working as before).
  • Removes duplication between dependency versions in workspace / py-polars manifest
  • Only a single target folder in the workspace - saves a whole bunch of space on my device and saves re-compiling things.

The Cargo.lock is now in the repo root, as well as the profile definitions. These will still be picked up by maturin and included in the sdist.

For some context, the official recommendation for Rust projects is now to check in the lockfile, even for libraries:
rust-lang/cargo#12382

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Nov 5, 2023
@stinodego stinodego marked this pull request as ready for review November 5, 2023 21:57
.github/workflows/test-python.yml Show resolved Hide resolved
@stinodego stinodego merged commit d5cb4d1 into main Nov 5, 2023
27 checks passed
@stinodego stinodego deleted the workspace-pypolars branch November 5, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants