fix(python): Replace _kwargs in collect method (#19618)

pola-rs · Nov 16, 2024 · 7817fcf · 7817fcf
1 parent 5476332
commit 7817fcf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/py-polars/polars/lazyframe/frame.py b/py-polars/polars/lazyframe/frame.py
@@ -1953,6 +1953,14 @@ def collect(
         │ c   ┆ 6   ┆ 1   │
         └─────┴─────┴─────┘
         """
+        for k in _kwargs:
+            if k not in (  # except "private" kwargs
+                "new_streaming",
+                "post_opt_callback",
+            ):
+                error_msg = f"collect() got an unexpected keyword argument '{k}'"
+                raise TypeError(error_msg)
+
         new_streaming = _kwargs.get("new_streaming", False)
 
         if no_optimization or _eager:

diff --git a/py-polars/tests/unit/lazyframe/test_lazyframe.py b/py-polars/tests/unit/lazyframe/test_lazyframe.py
@@ -907,6 +907,11 @@ def test_collect_all(df: pl.DataFrame, no_optimization: bool) -> None:
     assert cast(float, out[1].item()) == 12.0
 
 
+def test_collect_unexpected_kwargs(df: pl.DataFrame) -> None:
+    with pytest.raises(TypeError, match="unexpected keyword argument"):
+        df.lazy().collect(common_subexpr_elim=False)  # type: ignore[call-overload]
+
+
 def test_spearman_corr() -> None:
     ldf = pl.LazyFrame(
         {