Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Decimal type #226

Merged
merged 9 commits into from
Jun 12, 2024
Merged

feat: add Decimal type #226

merged 9 commits into from
Jun 12, 2024

Conversation

universalmind303
Copy link
Collaborator

No description provided.

@Bidek56
Copy link
Collaborator

Bidek56 commented Jun 12, 2024

@universalmind303 Do we need to add documentation for this feature?
Should we add this test?

  test("writeParquet", (done) => {
    const df = pl.DataFrame([
      pl.Series("doo", [1, 2, 3], pl.Decimal),
      pl.Series("foo", [1, 2, 3], pl.UInt32),
      pl.Series("bar", ["a", "b", "c"]),
    ]);
    const pqFile = "./test.parquet";
    df.writeParquet(pqFile);
    const newDF = pl.readParquet(pqFile);
    expect(newDF).toFrameEqual(df);
    fs.rmSync(pqFile);
    done();
  });

@universalmind303 universalmind303 merged commit 9f1e2f1 into main Jun 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants