Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending game end info through FCM #67

Merged
merged 6 commits into from
Jun 7, 2023
Merged

Sending game end info through FCM #67

merged 6 commits into from
Jun 7, 2023

Conversation

mikolaj-pirog
Copy link
Member

closes #59

@mikolaj-pirog mikolaj-pirog added this to the Sprint 4 milestone Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 96.15% and project coverage change: -0.01 ⚠️

Comparison is base (8bfcfad) 94.61% compared to head (b090459) 94.60%.

❗ Current head b090459 differs from pull request most recent head d9a12ae. Consider uploading reports for the commit d9a12ae to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   94.61%   94.60%   -0.01%     
==========================================
  Files          18       18              
  Lines         761      779      +18     
  Branches       85       88       +3     
==========================================
+ Hits          720      737      +17     
- Misses         41       42       +1     
Impacted Files Coverage Δ
src/utils/commonRequest.ts 97.70% <96.00%> (-0.28%) ⬇️
src/routes/gameplay/fold.ts 96.66% <100.00%> (-0.21%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/utils/commonRequest.ts Outdated Show resolved Hide resolved
src/utils/commonRequest.ts Outdated Show resolved Hide resolved
@Kwasow Kwasow self-requested a review June 7, 2023 14:09
@Kwasow Kwasow merged commit d72f6ff into main Jun 7, 2023
@Kwasow Kwasow deleted the @aetn23/sendWinner branch June 7, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detecting end of the game and sending winner info
2 participants