Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code cleanup #43

Merged
merged 6 commits into from
May 13, 2023
Merged

General code cleanup #43

merged 6 commits into from
May 13, 2023

Conversation

Kwasow
Copy link
Member

@Kwasow Kwasow commented May 5, 2023

Mostly use await in favor of then() in requests, as it improves readability. I also fixed lint-staged, which was not linting files correctly.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14 ⚠️

Comparison is base (b202fb9) 89.54% compared to head (e64e16a) 89.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   89.54%   89.40%   -0.14%     
==========================================
  Files           8        8              
  Lines         306      302       -4     
  Branches       29       27       -2     
==========================================
- Hits          274      270       -4     
  Misses         32       32              
Impacted Files Coverage Δ
src/routes/createGame.ts 88.88% <ø> (ø)
src/routes/startGame.ts 98.11% <ø> (ø)
src/routes/joinGame.ts 91.66% <100.00%> (-0.65%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/routes/joinGame.ts Outdated Show resolved Hide resolved
@Kwasow Kwasow merged commit 46e6ac9 into main May 13, 2023
@Kwasow Kwasow deleted the @kwasow/cleanup branch May 13, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants