Modify Game #34
Closed
Modify Game #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 79.83% 78.36% -1.47%
==========================================
Files 4 7 +3
Lines 119 208 +89
Branches 13 28 +15
==========================================
+ Hits 95 163 +68
- Misses 24 45 +21
☔ View full report in Codecov by Sentry. |
Kwasow
requested changes
Apr 28, 2023
| }), | ||
| }), | ||
| async (req, res) => { | ||
| if ( |
There was a problem hiding this comment.
I think you copied this if statement from kick player and it doesn't really make sense
|
|
||
| return res.sendStatus(200) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
We have to notify all players that the settings changed through FCM
Merged
|
Replaced by #36 |
Kwasow
added a commit
that referenced
this pull request
Apr 29, 2023
This is a replacement for #34 --------- Co-authored-by: aetn23 <mikolajpirog@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.