Database setup #25
Merged
Database setup #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
===========================================
+ Coverage 26.31% 51.21% +24.90%
===========================================
Files 3 3
Lines 19 41 +22
Branches 0 2 +2
===========================================
+ Hits 5 21 +16
- Misses 14 20 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mikolaj-pirog
approved these changes
Mar 23, 2023
sormys
reviewed
Mar 23, 2023
sormys
requested changes
Mar 23, 2023
sormys
approved these changes
Mar 23, 2023
Merged
Kwasow
pushed a commit
that referenced
this pull request
Mar 31, 2023
Adds get response to server to createGame. Adds `celebrate` as dependency to validate data. This needs database setup per #25. Error messages are generated automatically through celebrate. We needed to employ special function to change error response. Unfortunately celebrate does not easily allow to change http code per error. Generation of new random keys is done in database, as this is easier and more elegant. Database's definitions have been changed, see `databaseConnection.ts` Firebase token validation is yet to be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some setup is required.
src/secrets.tswith the contents:yarn startsetup tunneling with:yarn startIf everything worked correctly, you should see two tables created under your account:
GamesandPlayers.Closes #4