Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added autoformatting and linter. #19

Merged
merged 5 commits into from
Mar 18, 2023
Merged

Added autoformatting and linter. #19

merged 5 commits into from
Mar 18, 2023

Conversation

sormys
Copy link
Member

@sormys sormys commented Mar 17, 2023

No description provided.

@sormys sormys merged commit da3b622 into main Mar 18, 2023
@sormys sormys deleted the AddingPrettier branch March 18, 2023 11:15
Kwasow added a commit that referenced this pull request Mar 18, 2023
@Kwasow
Revert "Added autoformatting and linter. (#19)"
9003d2a 
This reverts commit da3b622.
@Kwasow
Copy link
Member

Kwasow commented Mar 18, 2023

This PR still needs some work @sormys. It does not run on Linux (missing executable permission on .husky/pre-commit and the pre-commit hook should run prettier first, and then eslint. Otherwise we do not gain anything from using prettier - we would still have to fix everything by hand, because eslint will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikolaj-pirog mikolaj-pirog mikolaj-pirog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sormys @Kwasow @mikolaj-pirog