Feat: Generate AST nodes only for rules that begin with a capital letter #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This really should be optional (i.e. a command line flag), otherwise it would break lots of things built with peg. |
|
Rule names that start with an underscore could be ignored. |
|
No, that has the exact same problem, and just looks worse. I'm just saying that there needs to be some way to disable it, for the sake of backward compatability. |
|
The syntax: 'Rule <= Ignored' could be added. Rules that are not ignored would still be 'Rule <- NotIgnored'. |
|
I guess that would work, but the syntax is non-obvious. I do like the idea of using capitalization, as it mirrors go's own behavior with (un)exported function. I simply think there needs to be a flag to turn it off. |
|
flag implemented: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #98.