Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-derive Derivable Conformances #14

Merged
merged 7 commits into from
Dec 6, 2019
Merged

Auto-derive Derivable Conformances #14

merged 7 commits into from
Dec 6, 2019

Conversation

stephencelis
Copy link
Member

For some reason I thought conditional conformance wasn't derivable. It is!

@stephencelis
Copy link
Member Author

Ha, guess this is new in Swift 4.2! It also failed in pointfreeco/swift-nonempty#7

Maybe we hold off...

@tonyarnold
Copy link
Contributor

Is this still relevant? It looks like it should work with Swift 5.1?

@mbrandonw mbrandonw mentioned this pull request Dec 6, 2019
@mbrandonw
Copy link
Member

@tonyarnold yes this should now be possible! just wanna upgrade the repo to Swift 5.1 (#38) and run tests on linux to make sure everything is good to go.

Thanks!

@stephencelis stephencelis merged commit 4e7fa84 into master Dec 6, 2019
@stephencelis stephencelis deleted the auto-derive branch December 6, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants