Edit 04-Navigation-Lists-NavigateAndLoad file in SwiftUI CaseStudies

[MaraMincho]

I found the if let code in the 04-Navigation-Lists-NavigateAndLoad file and made significant modifications to improve it. However, I'm concerned that these changes might unintentionally alter the original intent.

I would appreciate your feedback. Thank you!"

[stephencelis]

Thanks for the PR! This case study has definitely fallen behind the other examples and should probably be overhauled from scratch, but I think it'd be good to get these fixes merged.

The one change I think we should revert, though, is the change of Identified domain. Can you address that and the other comment below? Then we'll be happy to merge!

[stephencelis]

While this makes the EmptyReducer stuff less awkward, it unfortunately makes the domain modeled less precisely. It's not ideal, but let's return to using Identified for now.

[MaraMincho]

Thanks for the code review. As you suggested, I proceeded with the refactor using Identified. However, I encountered an issue. When trying to apply the comment(use sending method) to the selection in NavigationLink, refactoring with Identified resulted in an inability to use the sending method.

NavigationLink(
   // ....
   selection: $store.selection?.id.sending(\.setNavigation) // Compile Error
)

As a workaround, I had to implement the selection using a get and set approach.
If you have any suggestions for a better solution, I'd appreciate your feedback. Thank you

[MaraMincho]

Additionally, the original code state.selection?.value = Counter.State(count: state.rows[id: id]?.count ?? 0) was causing an Overlapping accesses error, so I assigned the value to a separate variable to resolve this.

case .setNavigationSelectionDelayCompleted:
    guard let id = state.selection?.id else { return .none }
    // ErrorMessage: Overlapping accesses to 'state', but modification requires exclusive access; consider copying to a local variable
    state.selection?.value = Counter.State(count: state.rows[id: id]?.count ?? 0)
    return .none

[stephencelis]

At the end of the day I think this is an improvement to case study that we're not super happy with at the moment, so I think we're good to merge this as a first step to improve things. Thanks!

We'll maybe rethink this case study in the future.