Add Store.send(_ action:) return StoreTask #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Aug 22, 2023
…ure to from: "0.58.2" (#522) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | minor | `from: "0.56.0"` -> `from: "0.58.2"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v0.58.2`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/0.58.2) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/0.58.1...0.58.2) #### What's Changed - Fixed: Back-ported a deprecation warning fix for `TestStore.init` (thanks [@​AndreaRomani](https://togithub.com/AndreaRomani), [https://github.com/pointfreeco/swift-composable-architecture/pull/2378](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2378)). #### New Contributors - [@​AndreaRomani](https://togithub.com/AndreaRomani) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2378](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2378) **Full Changelog**: pointfreeco/swift-composable-architecture@0.58.1...0.58.2 ### [`v0.58.1`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/0.58.1) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/0.58.0...0.58.1) #### What's Changed - Fixed: Hard deprecated a few more soft-deprecated APIs for ease of migration ([https://github.com/pointfreeco/swift-composable-architecture/pull/2376](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2376)). **Full Changelog**: pointfreeco/swift-composable-architecture@0.58.0...0.58.1 ### [`v0.58.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/0.58.0) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/0.57.0...0.58.0) #### What's Changed - Added: Allow chaining into `BindingViewState` ([https://github.com/pointfreeco/swift-composable-architecture/pull/2334](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2334)). - Deprecated: The old alert/dialog APIs have been hard-deprecated in favor of the newer presentation APIs ([https://github.com/pointfreeco/swift-composable-architecture/pull/2335](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2335)). - Infrastructure: Fix compiler error in tutorial ([https://github.com/pointfreeco/swift-composable-architecture/pull/2331](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2331)); make some small improvements to Standups demo ([https://github.com/pointfreeco/swift-composable-architecture/pull/2333](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2333)). **Full Changelog**: pointfreeco/swift-composable-architecture@0.57.0...0.58.0 ### [`v0.57.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/0.57.0) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/0.56.0...0.57.0) #### What's Changed - Changed: Prerelease 1.0 has been merged into this release ([https://github.com/pointfreeco/swift-composable-architecture/pull/1929](https://togithub.com/pointfreeco/swift-composable-architecture/pull/1929)). It includes numerous deprecations to help folks prepare for 1.0. - Changed: `BindingAction`'s custom dump format now abbreviates its value ([https://github.com/pointfreeco/swift-composable-architecture/pull/2315](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2315)). - Added: `Store.publisher` as an alternate to `ViewStore.publisher` ([https://github.com/pointfreeco/swift-composable-architecture/pull/2330](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2330)). - Fixed: Use Concurrency Extras' `Task.cancellableValue` instead of redefining it (thanks [@​Ryu0118](https://togithub.com/Ryu0118), [https://github.com/pointfreeco/swift-composable-architecture/pull/2310](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2310)). - Fixed: `TestStore.init(initialState:reducer:prepareDependencies:file:line:)` deprecation suggestion has been corrected (thanks [@​Ryu0118](https://togithub.com/Ryu0118), [https://github.com/pointfreeco/swift-composable-architecture/pull/2313](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2313)). - Fixed: Update `Store.send(_ action:)` to return `StoreTask` (thanks [@​hj56775](https://togithub.com/hj56775), [https://github.com/pointfreeco/swift-composable-architecture/pull/2323](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2323)). - Infrastructure: Remove unneeded `await`s from tests (thanks [@​Ryu0118](https://togithub.com/Ryu0118), [https://github.com/pointfreeco/swift-composable-architecture/pull/2312](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2312)). - Infrastructure: Fixed typo in `withTaskCancellation`'s debounce documentation (thanks [@​brzzdev](https://togithub.com/brzzdev), [https://github.com/pointfreeco/swift-composable-architecture/pull/2319](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2319)). **Full Changelog**: pointfreeco/swift-composable-architecture@0.56.0...0.57.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Mi4xIiwidXBkYXRlZEluVmVyIjoiMzYuNTIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the addition of Store.send is very innovative because it makes it clear that the View does not need to observe changes in State.
However, I noticed that Store.send is not returning a StoreTask, unlike ViewStore.send.
I want Store.send to also use
.task { await store.send(.task).finish() }, just like ViewStore.Is there any reason why Store.send isn't implemented that way?
If so, you can ignore this PR.
Thanks.