Correct some comments in Effect.swift #2081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
added a commit
that referenced
this pull request
May 30, 2023
* wip * fix * wip * wip * move * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Fix * wip * wip * Renamed action to onTap in NavigationLinkStore (#2043) Renamed the `action` parameter to mirror other inits and differentiate itself from `action fromDestinationAction` * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Tie view identity to stack element identity * Tie item identity to case * wip * wip * cleanup * fix * fix * Add warning to nav link * wip * wip * Rename FullscreenCover.swift to FullScreenCover.swift (#2062) * wip * fix isDetailLink on non-iOS platforms * Correct some comments in Effect.swift (#2081) * add integration tests for showing alert/dialog from alert/dialog. * copy StackElementIDGenerator dependency before running TestStore receive closure. * Removed some unneeded delegate actions. * wip * clean up * lots of clean up * Converted voice memos back to identified array * update deps * update docs for DismissEffect * wip * Add Sendable conformance to PresentationState (#2086) * wip * swift-format * wip * wip * docs * wip * wip * Catch some typos in Articles (#2088) * wip * wip * wip * wip * wip * docs * wip * wip * docs * wip * wip * wip * wip * docs * docs * wip * wip * wip * wip * wip * wip * wip * Fix invalid states count for 3 optionals and typos (#2094) * wip * wip * more dismisseffect docs * fixed some references * navigation doc corrections * more nav docs * fix cancellation tests in release mode * wrap some tests in #if DEBUG since they are testing expected failures * update UUIDs in tests to use shorter initializer * fixed a todo * wip * fix merge errors * wip * fix * wip * wip * fixing a bunch of todos * get rid of rawvalue in StackElementID * more todos * NavLinkStore docs * fix swift 5.6 stuff * fix some standups tests * fix * clean up * docs fix * fixes * wip * 5.6 fix * wip * wip * dont parallelize tests * updated demo readmes * wip * Use ObservedObject instead of StateObject for alert/dialog modifiers. * integration tests for bad dismissal behavior * check for runtime warnings in every integration test * wip * wip * fix * wip * wip * wip * wip * wip * Drop a bunch of Hashables. * some nav bug fixes * wip * wip * wip * fix * fix * wip * wip * Simplify recording test. * add concurrent async test * fix * wip * Refact how detail dismisses itself. * fix * 5.6 fix * wip * wip * Add TestStore.assert. * Revert "Add TestStore.assert." This reverts commit a892ccc. * add Ukrainian Readme.md (#2121) * Add TestStore.assert. (#2123) * Add TestStore.assert. * wip * Update Sources/ComposableArchitecture/TestStore.swift Co-authored-by: Stephen Celis <stephen@stephencelis.com> * Update Sources/ComposableArchitecture/Documentation.docc/Extensions/TestStore.md Co-authored-by: Stephen Celis <stephen@stephencelis.com> * fix tests --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> * Run swift-format * push for store.finish and presentation * move docs around * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Add case subscripts * wip * wip * 5.7-only * wip * wip * wip * wip * revert store.finish task cancellation * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * add test for presentation scope * wip * wip * wip * wip * wip * cleanup * updated presentation scope test * sytnax update * clean up * fix test * wip * wip * wip * wip * wip --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com> Co-authored-by: Martin Václavík <mvaclavik96@icloud.com> Co-authored-by: 유재호 <y73447jh@gmail.com> Co-authored-by: Jackson Utsch <jutechs@gmail.com> Co-authored-by: Dmytro <barabashdmyto@gmail.com> Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com> Co-authored-by: mbrandonw <mbrandonw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again!
I corrected two small mistakes in the
Effect.swiftfile. Please review the changes. 😄