forked from kubernetes/kubernetes
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
kubelet: revert contextual logging support
It turned out that using testing.T for logging had a race condition and potential panic because the tests keep goroutines running and testing.T is not supposed to be used anymore after test completion (kubernetes#110854). Either the code must be fixed to terminate all goroutines before a test ends (seems non-trivial because the usage of goroutines is fairly complex in the shutdown manager code), or ktesting must handle this case. A solution for this is pending in kubernetes/klog#337. Either way, solving this will take a bit longer. In the meantime, we should revert the change to get unit testing stable again. In order to make this a local change, ktesting is kept as a dependency of the test and thus Kubernetes.
- Loading branch information
Showing
5 changed files
with
58 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters