Metrics: WorkClaim Counts #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrenv
reviewed
Oct 23, 2018
src/API/WorkController.ts
Outdated
| async getWorksCountByFilters(worksFilters: WorksFilters = {}): Promise<WorkCount> { | ||
| this.logger.trace({ method: 'getByFilters', worksFilters }, 'Getting Work by Filters from DB') | ||
| const count = await this.collection.find(worksFilters, { projection: { _id: false } }).count() | ||
| return { count } |
There was a problem hiding this comment.
Can we just return an integer here instead of an object? It would better match the function name.
There was a problem hiding this comment.
Yeah that makes sense. I updated it.
warrenv
approved these changes
Oct 23, 2018
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Process - PR Review Checklist
Release
Semantic release is enabled for this repository. Make sure you follow the right commit message convention.
We're using semantic-release's default — Angular Commit Message Conventions.
Description of Changes
Resolves #626
API
Router
/metricsendpointgetWorkCountsWorkController
getWorksCountByFiltersNotes
Should I include integration/functional tests either in this PR or in an additional one?