-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pods 2.8 i18n integration classes #6155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored from PodsI18n
sc0ttkclark
reviewed
Oct 5, 2021
sc0ttkclark
reviewed
Oct 5, 2021
sc0ttkclark
reviewed
Oct 5, 2021
sc0ttkclark
reviewed
Oct 5, 2021
sc0ttkclark
reviewed
Oct 5, 2021
sc0ttkclark
previously approved these changes
Oct 5, 2021
@JoryHogeveen is #5945 confirmed resolved by this now? We can go ahead and merge this ahead of the WPML call too, it's a major improvement |
@sc0ttkclark |
sc0ttkclark
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Focus: i18n
Status: PR > QA pending
QA needs to be done
Status: PR > Reviewed and Ready
PR has been code reviewed by core developers and is ready for merge (if it passes QA)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moved all i18n compatibility for third party plugins (WPML and Polylang) to dedicated integration classes.
Related GitHub issue(s)
Related: #5029
Tasklist
Testing instructions
[pods name="test"]{@title} [/pods]
where
statements etc.) keep working correctly.Changelog text for these changes
PR checklist