JS: jQuery.fn.size() is deprecated #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `.length` property instead. Fixes #3898
GaryJones
added
Type: Clean up / refactor
Status: PR > Pending Code Review
ghost
added
the
Status: In Progress
pglewis
approved these changes
Jun 5, 2018
pglewis
added
Status: PR > Reviewed and Ready
sc0ttkclark
approved these changes
Jun 5, 2018
ghost
removed
the
Status: In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
.lengthproperty instead.Fixes #3898
Only one instance of
size()existed, compared to the two mentioned in #3898.