Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"download" attr + Button action wrapper + JS i18n + Improve CSS UI + replace deprecated functions #3592

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Jun 23, 2016

Related: #3591

Download attr + action wrapper to improve button aligning + Improve CSS UI

@jimtrue jimtrue added the Status: In Progress Issue or PR is currently in progress but not yet done label Jun 23, 2016
@JoryHogeveen
Copy link
Member Author

JoryHogeveen commented Jun 23, 2016

Commit 15ee8c5 merges PR #3586 (Make javascript strings translatable + fix deprecated var functions from ui/admin/*.php)

@JoryHogeveen JoryHogeveen changed the title Download attr + action wrapper to improve button aligning + Improve CSS UI "download" attr + Button action wrapper + JS i18n + Improve CSS UI + replace deprecated functions Jun 23, 2016
@sc0ttkclark
Copy link
Member

In the future, split the PR up so the translation stuff was in it's own PR. Will work with it as is now though

@sc0ttkclark sc0ttkclark added this to the Pods 2.7 milestone Jun 23, 2016
@sc0ttkclark sc0ttkclark self-assigned this Jun 23, 2016
@JoryHogeveen
Copy link
Member Author

JoryHogeveen commented Jun 23, 2016

Oh sorry, that seems logical indeed...
JS is fairly straight forward, so is the replacement for depreciated functions (I changed it to the same functions that the depreciated ones would have done).

EDIT: There are a lot more references to the pods_var_raw etc. So I think it would be good to swipe it all for the 2.7 release. At least it's done then :)

@sc0ttkclark sc0ttkclark merged commit 6bab43e into pods-framework:feature/#3364-2.7-Feature-Release Jun 23, 2016
@sc0ttkclark sc0ttkclark removed the Status: In Progress Issue or PR is currently in progress but not yet done label Jun 23, 2016
@JoryHogeveen JoryHogeveen added the Type: Enhancement Enhancements to features that already exist, but are not major additions label Jul 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Enhancements to features that already exist, but are not major additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants