Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New MV based Pick field as full drop-in replacement #3695

Closed
5 tasks done
pglewis opened this issue Jul 21, 2016 · 1 comment
Closed
5 tasks done

New MV based Pick field as full drop-in replacement #3695

pglewis opened this issue Jul 21, 2016 · 1 comment
Assignees
@pglewis
Labels
Keyword: Focus This is a major focus of a release
Milestone
Pods 2.7

Comments

@pglewis
Copy link
Contributor

pglewis commented Jul 21, 2016 •
edited
Loading

PR: #3697

We cannot easily implement the new pick field in parallel with the old one due to the special treatment we give to 'pick' throughout core. The next major step is for the re-built pick field to fully replace the old one.

Add New Pod:

  • Track down and fix up issues with depends-on/excludes-on for select lists

Fix Pod Edit screen:

  • Find what's snagging in the JS collapsible method when clicking edit on a field
  • Rework pods_sister_field JS function
  • Selected attribute not being set on initialization for some lists (field type is one culprit)
  • Track down slow initial load when expanding the collapsible field row
@pglewis pglewis added the Keyword: Focus This is a major focus of a release label Jul 21, 2016
@pglewis pglewis added this to the Pods 2.7 milestone Jul 21, 2016
@pglewis pglewis self-assigned this Jul 21, 2016
@pglewis pglewis changed the title New MV base Pick field as full drop-in replacement New MV based Pick field as full drop-in replacement Jul 21, 2016
@pglewis pglewis added the Status: In Progress Issue or PR is currently in progress but not yet done label Jul 21, 2016
@pglewis pglewis mentioned this issue Jul 21, 2016
Closed
pglewis added a commit that referenced this issue Jul 21, 2016
@pglewis
#3695 initial work:
7318e05 
  * remove "view selector" left over from prototyping
  * only show the add new button if an `iframe_src` has been set
  * determine the proper view to be used from the field options
  * patch up the pick.php files (classes/fields and ui/fields-mv) to only use the new mv fields
This was referenced Jul 21, 2016
Merged
Closed
@pglewis
Copy link
Contributor Author

pglewis commented Aug 6, 2016

Now that we can create and edit Pods, this is ready to merge back in.

@pglewis pglewis closed this as completed Aug 6, 2016
@pglewis pglewis removed the Status: In Progress Issue or PR is currently in progress but not yet done label Aug 6, 2016
pglewis added a commit that referenced this issue Aug 6, 2016
@pglewis
Merge pull request #3697 from pods-framework/feature/#3695-pick-repla…
6972227 
…cement

Feature/#3695 pick replacement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pglewis pglewis

Labels
Keyword: Focus This is a major focus of a release
Projects
None yet
Milestone
Pods 2.7
Development

No branches or pull requests
1 participant
@pglewis