Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: register cli tool #78

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix: register cli tool #78

merged 2 commits into from
Jul 25, 2024

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Jul 18, 2024 •
edited
Loading

It enable the registration of the minikube cli tool and its updater

image

it resolves #74

@lstocchi lstocchi force-pushed the i74 branch 2 times, most recently from 82538e3 to 43148d9 Compare July 18, 2024 12:17
@lstocchi lstocchi marked this pull request as ready for review July 18, 2024 12:18
@lstocchi lstocchi requested review from benoitf and a team as code owners July 18, 2024 12:18
@lstocchi lstocchi requested a review from jeffmaury July 18, 2024 12:19
axel7083
axel7083 reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the cli is registered when the binary is download in the extension-storage and not installed system wide ?

@lstocchi
Copy link
Contributor Author

Does the cli is registered when the binary is download in the extension-storage and not installed system wide ?

Yes, why?

jeffmaury
jeffmaury approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lstocchi added 2 commits July 25, 2024 10:51
@lstocchi
fix: register cli tool
820c111 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi
fix: add tests
9391298 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi merged commit 52c33f4 into podman-desktop:main Jul 25, 2024
4 checks passed
@lstocchi lstocchi deleted the i74 branch July 25, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axel7083 axel7083 axel7083 approved these changes

@jeffmaury jeffmaury jeffmaury approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube extension should register CLI Tool
3 participants
@lstocchi @jeffmaury @axel7083