fix: Donation wish not being created after successfull donation #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Not all tests have run for this PR. Please add the |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
imilchev
reviewed
Jul 15, 2024
| const newDonation = await this.createIncomingDonation( | ||
| tx, | ||
| paymentData, | ||
| newDonationStatus, | ||
| campaign, | ||
| ) | ||
| donationId = newDonation.id | ||
| donationId = newDonation.donations[0].id |
There was a problem hiding this comment.
is it always just 1 donation? can this be 0 or more than 1?
There was a problem hiding this comment.
At this point it will always be 1 donation.
slavcho
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was detected where, donation wishes aren't imported on charge.succeeded event.