add helpUsImprove field to the backend

[kdachev97]

This ticket is related to the frontend ticket: feature/add-tickbox-to-registration-field

Added the helpUsImprove field to the schema.prisma and register.dto.ts files as requested

[github-actions]

✅ Tests will run for this PR. Once they succeed it can be merged.

[sashko9807]

Great job!
When changing the prisma schema in order for those changes to be implemented in the database we need to run yarn prisma migrate dev. This command will automatically generate the SQL query to add the help_us_improve field to the persons table, as well as auto-generating the changes for the Prisma Client.

Once yarn prisma migrate dev is finished, execute yarn format, which will run prettier on all generated.

So in summary:

1. Run yarn prisma migrate dev to generate the SQL query which updates the person table
2. Run yarn format - to prettify the generated Prisma clients.
3. Commit the changes.

If you have further questions regarding the requested changes, feel free to contact me.

[sashko9807]

There is a typo. Change to helpUsImprove
We use snake_case for referencing a field via raw SQL query. Would you please add @Map("help_us_improve") at the end of this line.
Example:

helpUsImporve      Boolean?            @default(false) @map("help_us_improve")

[sashko9807]

Please fix the typo, as well as add @map("help_us_improve"), as we use snake_case for referencing db fields directly

helpUsImporve      Boolean?            @default(false) @map("help_us_improve")

Then re-execute the yarn prisma migrate dev and yarn format

Edit: Linter is failing due to missing field field in personMock.
After you fix the above typo, please add helpUsImprove field to the personMock.ts

[kdachev97]

Should I delete the previous migration? На пн, 18.03.2024 г. в 14:01 Aleksandar Petkov ***@***.***> написа:

…

***@***.**** requested changes on this pull request. ------------------------------ In schema.prisma <#615 (comment)>: > @@ -40,6 +40,7 @@ model Person { updatedAt DateTime? @updatedAt @Map("updated_at") @db.Timestamptz(6) // Receive marketing notifications newsletter Boolean? @default(false) + helpUsImporve Boolean? @default(false) Please fix the typo, as well as add @Map("help_us_improve"), as we use snake_case for referencing db fields directly helpUsImporve Boolean? @default(false) @Map("help_us_improve") Then re-execute the yarn prisma migrate dev and yarn format — Reply to this email directly, view it on GitHub <#615 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDTQ7QAMKIAKJ4RDPAXGY7DYY3JSBAVCNFSM6AAAAABE2J2UI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBSG43DCOJVGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[sashko9807]

Should I delete the previous migration?

It would be best if you can. As it will keep the migration folder more tidier.

Please fix the typo, as well as add @map("help_us_improve"), as we use snake_case for referencing db fields directly.
Example:

helpUsImprove      Boolean?            @default(false) @map("help_us_improve")

Then re-execute the yarn prisma migrate dev and yarn format
Once the commands from above are executed, please also fix the failing API test job due to missing helpUsImprove field in personMock.ts, e.g. just add helpUsImprove at the end of the object.

[sashko9807]

Hmm. apparently I forgot to tell you to add the following line:

helpUsImprove: registerDto.helpUsImprove ? registerDto.helpUsImprove : false

to the person.upsert method here. Do yo mind adding it? Sorry for that.

[kdachev97]

Do I need to run new migrations or is it just that? На пн, 18.03.2024 г. в 19:19 Aleksandar Petkov ***@***.***> написа:

…

Hmm. apparently I forgot to tell you to add the following line: helpUsImprove: registerDto.helpUsImprove ? registerDto.helpUsImprove : false to the person.upsert method here <https://github.com/podkrepi-bg/api/blob/master/apps/api/src/auth/auth.service.ts#L295>. Do yo mind adding it? Sorry for that. — Reply to this email directly, view it on GitHub <#615 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDTQ7QBH5O73GYSGC3Q3C4DYY4O2XAVCNFSM6AAAAABE2J2UI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGUYDMOBXGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[sashko9807]

Do I need to run new migrations or is it just that?

Just that change. Everything regarding the migration is OK.