Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate types from JSDoc #233

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: generate types from JSDoc #233

merged 1 commit into from
Apr 23, 2024

Conversation

wkillerud
Copy link
Contributor

@wkillerud wkillerud commented Apr 23, 2024

TypeScript Tuesday 🙌 It's a large diff, sorry about that.

Goals:

  • Generate type definitions from JSDoc.
  • Test type definitions locally by typechecking unit tests.

@leftieFriele leftieFriele self-requested a review April 23, 2024 12:32
Copy link

@leftieFriele leftieFriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections, I applaud resisting the temptation to not rewrite the tests to using the node native test runner 😄

@wkillerud wkillerud merged commit 53200f4 into master Apr 23, 2024
7 checks passed
@wkillerud wkillerud deleted the jsdoc-tsc branch April 23, 2024 13:00
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
## [5.0.4](v5.0.3...v5.0.4) (2024-04-23)

### Bug Fixes

* generate types from JSDoc ([#233](#233)) ([53200f4](53200f4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants