Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error event listeners on all metric streams #10

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Add error event listeners on all metric streams #10

merged 2 commits into from
Mar 5, 2019

Conversation

trygve-lie
Copy link
Contributor

This adds error event listeners on the metric stream. Guards against errors in the stream.

@trygve-lie trygve-lie requested a review from digitalsadhu March 4, 2019 12:47
digitalsadhu
digitalsadhu approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@digitalsadhu digitalsadhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trygve-lie trygve-lie merged commit 2f8f623 into master Mar 5, 2019
@trygve-lie trygve-lie deleted the error-listeners branch March 5, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalsadhu digitalsadhu digitalsadhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trygve-lie @digitalsadhu