enh: #3890: Get rid of SingletonHolder

pocoproject · Jan 30, 2024 · d5a5ebc · siren186 · May 14, 2024 · d5a5ebc
1 parent 33638df
commit d5a5ebc
Show file tree

Hide file tree

Showing 23 changed files with 44 additions and 168 deletions.
diff --git a/ApacheConnector/src/ApacheApplication.cpp b/ApacheConnector/src/ApacheApplication.cpp
@@ -11,7 +11,6 @@
 #include "ApacheApplication.h"
 #include "ApacheChannel.h"
 #include "Poco/Logger.h"
-#include "Poco/SingletonHolder.h"
 #include <vector>
 
 
@@ -48,6 +47,6 @@ void ApacheApplication::setup()
 
 ApacheApplication& ApacheApplication::instance()
 {
-	static Poco::SingletonHolder<ApacheApplication> sh;
-	return *sh.get();
+	static ApacheApplication aa;
+	return aa;
 }
diff --git a/Crypto/src/CipherFactory.cpp b/Crypto/src/CipherFactory.cpp
@@ -20,7 +20,6 @@
 #include "Poco/Crypto/RSACipherImpl.h"
 #include "Poco/Crypto/EVPCipherImpl.h"
 #include "Poco/Exception.h"
-#include "Poco/SingletonHolder.h"
 #include <openssl/evp.h>
 #include <openssl/err.h>
 #if OPENSSL_VERSION_NUMBER >= 0x30000000L
@@ -46,15 +45,10 @@ CipherFactory::~CipherFactory()
 }
 
 
-namespace
-{
-	static Poco::SingletonHolder<CipherFactory> holder;
-}
-
-
 CipherFactory& CipherFactory::defaultFactory()
 {
-	return *holder.get();
+	static CipherFactory cf;
+	return cf;
 }
 
 

diff --git a/Data/MySQL/src/SessionHandle.cpp b/Data/MySQL/src/SessionHandle.cpp
@@ -14,7 +14,6 @@
 
 #include "Poco/Data/MySQL/SessionHandle.h"
 #include "Poco/Data/DataException.h"
-#include "Poco/SingletonHolder.h"
 #ifdef POCO_OS_FAMILY_UNIX
 #include <pthread.h>
 #endif
@@ -51,7 +50,8 @@ class ThreadCleanupHelper
 
 	static ThreadCleanupHelper& instance()
 	{
-		return *_sh.get();
+		static ThreadCleanupHelper tch;
+		return tch;
 	}
 
 	static void cleanup(void* data)
@@ -61,11 +61,9 @@ class ThreadCleanupHelper
 
 private:
 	pthread_key_t _key;
-	static Poco::SingletonHolder<ThreadCleanupHelper> _sh;
 };
 
 
-Poco::SingletonHolder<ThreadCleanupHelper> ThreadCleanupHelper::_sh;
 #endif
 
 

diff --git a/Foundation/src/ActiveThreadPool.cpp b/Foundation/src/ActiveThreadPool.cpp
@@ -352,14 +352,9 @@ class ActiveThreadPoolSingletonHolder
 };
 
 
-namespace
-{
-	static ActiveThreadPoolSingletonHolder sh;
-}
-
-
 ActiveThreadPool& ActiveThreadPool::defaultPool()
 {
+	static ActiveThreadPoolSingletonHolder sh;
 	return *sh.pool();
 }
 

diff --git a/Foundation/src/ErrorHandler.cpp b/Foundation/src/ErrorHandler.cpp
@@ -13,7 +13,6 @@
 
 
 #include "Poco/ErrorHandler.h"
-#include "Poco/SingletonHolder.h"
 
 
 namespace Poco {
@@ -103,11 +102,8 @@ ErrorHandler* ErrorHandler::set(ErrorHandler* pHandler)
 
 ErrorHandler* ErrorHandler::defaultHandler()
 {
-	// NOTE: Since this is called to initialize the static _pHandler
-	// variable, sh has to be a local static, otherwise we run
-	// into static initialization order issues.
-	static SingletonHolder<ErrorHandler> sh;
-	return sh.get();
+	static ErrorHandler eh;
+	return &eh;
 }
 
 

diff --git a/Foundation/src/LoggingFactory.cpp b/Foundation/src/LoggingFactory.cpp
@@ -13,7 +13,6 @@
 
 
 #include "Poco/LoggingFactory.h"
-#include "Poco/SingletonHolder.h"
 #include "Poco/AsyncChannel.h"
 #include "Poco/ConsoleChannel.h"
 #include "Poco/FileChannel.h"
@@ -73,15 +72,10 @@ Formatter::Ptr LoggingFactory::createFormatter(const std::string& className) con
 }
 
 
-namespace
-{
-	static SingletonHolder<LoggingFactory> sh;
-}
-
-
 LoggingFactory& LoggingFactory::defaultFactory()
 {
-	return *sh.get();
+	static LoggingFactory lf;
+	return lf;
 }
 
 

diff --git a/Foundation/src/LoggingRegistry.cpp b/Foundation/src/LoggingRegistry.cpp
@@ -13,7 +13,6 @@
 
 
 #include "Poco/LoggingRegistry.h"
-#include "Poco/SingletonHolder.h"
 
 
 namespace Poco {
@@ -102,15 +101,10 @@ void LoggingRegistry::clear()
 }
 
 
-namespace
-{
-	static SingletonHolder<LoggingRegistry> sh;
-}
-
-
 LoggingRegistry& LoggingRegistry::defaultRegistry()
 {
-	return *sh.get();
+	static LoggingRegistry lr;
+	return lr;
 }
 
 

diff --git a/Foundation/src/NestedDiagnosticContext.cpp b/Foundation/src/NestedDiagnosticContext.cpp
@@ -13,7 +13,6 @@
 
 
 #include "Poco/NestedDiagnosticContext.h"
-#include "Poco/SingletonHolder.h"
 #include "Poco/ThreadLocal.h"
 
 
@@ -114,15 +113,10 @@ void NestedDiagnosticContext::clear()
 }
 
 
-namespace
-{
-	static ThreadLocal<NestedDiagnosticContext> ndc;
-}
-
-
 NestedDiagnosticContext& NestedDiagnosticContext::current()
 {
-	return ndc.get();
+	static NestedDiagnosticContext ndc;
+	return ndc;
 }
 
 

diff --git a/Foundation/src/NotificationCenter.cpp b/Foundation/src/NotificationCenter.cpp
@@ -16,7 +16,6 @@
 #include "Poco/Notification.h"
 #include "Poco/Observer.h"
 #include "Poco/AutoPtr.h"
-#include "Poco/SingletonHolder.h"
 
 
 namespace Poco {
@@ -106,15 +105,10 @@ std::size_t NotificationCenter::countObservers() const
 }
 
 
-namespace
-{
-	static SingletonHolder<NotificationCenter> sh;
-}
-
-
 NotificationCenter& NotificationCenter::defaultCenter()
 {
-	return *sh.get();
+	static NotificationCenter nc;
+	return nc;
 }
 
 

diff --git a/Foundation/src/NotificationQueue.cpp b/Foundation/src/NotificationQueue.cpp
@@ -15,7 +15,6 @@
 #include "Poco/NotificationQueue.h"
 #include "Poco/NotificationCenter.h"
 #include "Poco/Notification.h"
-#include "Poco/SingletonHolder.h"
 
 
 namespace Poco {
@@ -209,15 +208,10 @@ Notification::Ptr NotificationQueue::dequeueOne()
 }
 
 
-namespace
-{
-	static SingletonHolder<NotificationQueue> sh;
-}
-
-
 NotificationQueue& NotificationQueue::defaultQueue()
 {
-	return *sh.get();
+	static NotificationQueue nq;
+	return nq;
 }
 
 

diff --git a/Foundation/src/PriorityNotificationQueue.cpp b/Foundation/src/PriorityNotificationQueue.cpp
@@ -15,7 +15,6 @@
 #include "Poco/PriorityNotificationQueue.h"
 #include "Poco/NotificationCenter.h"
 #include "Poco/Notification.h"
-#include "Poco/SingletonHolder.h"
 
 
 namespace Poco {
@@ -180,15 +179,10 @@ Notification::Ptr PriorityNotificationQueue::dequeueOne()
 }
 
 
-namespace
-{
-	static SingletonHolder<PriorityNotificationQueue> sh;
-}
-
-
 PriorityNotificationQueue& PriorityNotificationQueue::defaultQueue()
 {
-	return *sh.get();
+	static PriorityNotificationQueue pnq;
+	return pnq;
 }
 
 

diff --git a/Foundation/src/TextEncoding.cpp b/Foundation/src/TextEncoding.cpp
@@ -26,7 +26,6 @@
 #include "Poco/Windows1251Encoding.h"
 #include "Poco/Windows1252Encoding.h"
 #include "Poco/RWLock.h"
-#include "Poco/SingletonHolder.h"
 #include <map>
 
 
@@ -193,15 +192,10 @@ TextEncoding& TextEncoding::global()
 }
 
 
-namespace
-{
-	static SingletonHolder<TextEncodingManager> sh;
-}
-
-
 TextEncodingManager& TextEncoding::manager()
 {
-	return *sh.get();
+	static TextEncodingManager tem;
+	return tem;
 }
 
 

diff --git a/Foundation/src/ThreadLocal.cpp b/Foundation/src/ThreadLocal.cpp
@@ -13,7 +13,6 @@
 
 
 #include "Poco/ThreadLocal.h"
-#include "Poco/SingletonHolder.h"
 #include "Poco/Thread.h"
 
 
@@ -54,12 +53,6 @@ TLSAbstractSlot*& ThreadLocalStorage::get(const void* key)
 }
 
 
-namespace
-{
-	static SingletonHolder<ThreadLocalStorage> sh;
-}
-
-
 ThreadLocalStorage& ThreadLocalStorage::current()
 {
 	Thread* pThread = Thread::current();
@@ -69,7 +62,8 @@ ThreadLocalStorage& ThreadLocalStorage::current()
 	}
 	else
 	{
-		return *sh.get();
+		static ThreadLocalStorage tls;
+		return tls;
 	}
 }
 

diff --git a/Foundation/src/ThreadPool.cpp b/Foundation/src/ThreadPool.cpp
@@ -497,14 +497,9 @@ class ThreadPoolSingletonHolder
 };
 
 
-namespace
-{
-	static ThreadPoolSingletonHolder sh;
-}
-
-
 ThreadPool& ThreadPool::defaultPool()
 {
+	static ThreadPoolSingletonHolder sh;
 	return *sh.pool();
 }
 

diff --git a/Foundation/src/URIStreamOpener.cpp b/Foundation/src/URIStreamOpener.cpp
@@ -17,7 +17,6 @@
 #include "Poco/FileStreamFactory.h"
 #include "Poco/URI.h"
 #include "Poco/Path.h"
-#include "Poco/SingletonHolder.h"
 #include "Poco/Exception.h"
 
 
@@ -159,15 +158,10 @@ bool URIStreamOpener::supportsScheme(const std::string& scheme)
 }
 
 
-namespace
-{
-	static SingletonHolder<URIStreamOpener> sh;
-}
-
-
 URIStreamOpener& URIStreamOpener::defaultOpener()
 {
-	return *sh.get();
+	static URIStreamOpener so;
+	return so;
 }
 
 

diff --git a/Foundation/src/UUIDGenerator.cpp b/Foundation/src/UUIDGenerator.cpp
@@ -18,7 +18,6 @@
 #include "Poco/DigestEngine.h"
 #include "Poco/MD5Engine.h"
 #include "Poco/SHA1Engine.h"
-#include "Poco/SingletonHolder.h"
 #include <cstring>
 
 
@@ -152,15 +151,10 @@ void UUIDGenerator::seed(UInt32 n)
 }
 
 
-namespace
-{
-	static SingletonHolder<UUIDGenerator> sh;
-}
-
-
 UUIDGenerator& UUIDGenerator::defaultGenerator()
 {
-	return *sh.get();
+	static UUIDGenerator g;
+	return g;
 }