Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: workflows use node 16 everywhere #874

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

shpingalet007
Copy link
Collaborator

@shpingalet007 shpingalet007 commented Jan 18, 2023

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The workflow changes are stable, and I have tested them myself on the fork repository, to the best of my abilities.

Changes:

  • Update actions/setup-node to v3
  • Use node 16 everywhere

Other comments:

This PR is related to #873. Node 16 is mandatory for node-gyp to compile binary raw-socket node module.

Changes introduced in this PR could not break current workflow and are backward compatible.

* Update setup-node to v3
* Use node 16 everywhere
@shpingalet007 shpingalet007 added the contribution type: 🚦 maintanance Repository maintanance PR's and issues label Jan 18, 2023
@shpingalet007 shpingalet007 self-assigned this Jan 18, 2023
@shpingalet007
Copy link
Collaborator Author

shpingalet007 commented Jan 18, 2023

Tests of deploy.pulls.dev.yml (6/7 checked)

- Check results - | - Workflow code -
  • deploy-pre
  • deploy-test
  • build-proxy (skipped, no access to proxy_pull_up.sh script)
  • build-app-macos
  • build-app-unix
  • build-app-windows
  • build-app-android

@shpingalet007 shpingalet007 marked this pull request as ready for review January 18, 2023 16:30
@shpingalet007 shpingalet007 merged commit 52c22a5 into pocketnetteam:master Jan 18, 2023
@shpingalet007
Copy link
Collaborator Author

shpingalet007 commented Jan 18, 2023

After-merge report 1

@shpingalet007 shpingalet007 deleted the workflow-node-16 branch January 19, 2023 12:17
@shpingalet007 shpingalet007 restored the workflow-node-16 branch January 19, 2023 12:17
@shpingalet007
Copy link
Collaborator Author

After-merge report 2

@shpingalet007 shpingalet007 removed the request for review from maxgithubprofile January 19, 2023 12:20
MoMentalochka pushed a commit to MoMentalochka/pocketnet.gui-my that referenced this pull request Jan 25, 2023
* Update setup-node to v3
* Use node 16 everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution type: 🚦 maintanance Repository maintanance PR's and issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants